Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 08:42 +0100, Iago Toral wrote: On Wed, 2014-11-19 at 11:43 -0800, Jason Ekstrand wrote: A couple of specific comments are below. More generally, why are you only considering the base format on two cases? Do we never use it for anything else? I thought about that

Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-20 Thread Jason Ekstrand
On Wed, Nov 19, 2014 at 11:42 PM, Iago Toral ito...@igalia.com wrote: On Wed, 2014-11-19 at 11:43 -0800, Jason Ekstrand wrote: A couple of specific comments are below. More generally, why are you only considering the base format on two cases? Do we never use it for anything else? I

Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-19 Thread Jason Ekstrand
A couple of specific comments are below. More generally, why are you only considering the base format on two cases? Do we never use it for anything else? On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: Add a dst_internal_format parameter to _mesa_format_convert,

Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-19 Thread Iago Toral
On Wed, 2014-11-19 at 11:43 -0800, Jason Ekstrand wrote: A couple of specific comments are below. More generally, why are you only considering the base format on two cases? Do we never use it for anything else? I thought about that too but when I looked at the original code it seemed that it

[Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-18 Thread Iago Toral Quiroga
Add a dst_internal_format parameter to _mesa_format_convert, that represents the base internal format for texture/pixel uploads, so we can do the right thing when the driver has selected a different internal format for the target dst format. --- src/mesa/main/format_utils.c | 65