Re: [Mesa-dev] [PATCH 06/15] nir/algebraic: Improve error messages for replace expressions

2018-11-26 Thread Timothy Arceri
I'm no python expect but for what its worth patches 1-6 are: Reviewed-by: Timothy Arceri On 9/11/18 2:45 pm, Jason Ekstrand wrote: In bf441d22a7917f38c, I wrote a bunch of descriptive asserts for various bit size checks in the validation of search expressions. This commit improves a few of

[Mesa-dev] [PATCH 06/15] nir/algebraic: Improve error messages for replace expressions

2018-11-08 Thread Jason Ekstrand
In bf441d22a7917f38c, I wrote a bunch of descriptive asserts for various bit size checks in the validation of search expressions. This commit improves a few of those and adds descriptive asserts for replace expressions as well. We also rework _validate_bit_class_down so that it can properly