Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-11 Thread Francisco Jerez
Iago Toral writes: > On Tue, 2016-05-10 at 16:53 -0700, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: Iago Toral Quiroga >> > >> > We were not accounting for reg_suboffset in the check for the start >> > of the region. This meant that would allow copy-propagation ev

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-11 Thread Francisco Jerez
Iago Toral writes: > On Tue, 2016-05-10 at 16:53 -0700, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: Iago Toral Quiroga >> > >> > We were not accounting for reg_suboffset in the check for the start >> > of the region. This meant that would allow copy-propagation ev

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-11 Thread Iago Toral
On Tue, 2016-05-10 at 16:53 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: Iago Toral Quiroga > > > > We were not accounting for reg_suboffset in the check for the start > > of the region. This meant that would allow copy-propagation even if > > the dst wrote to su

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-10 Thread Francisco Jerez
Francisco Jerez writes: > Samuel Iglesias Gonsálvez writes: > >> From: Iago Toral Quiroga >> >> We were not accounting for reg_suboffset in the check for the start >> of the region. This meant that would allow copy-propagation even if >> the dst wrote to sub_regoffset 4 and our source read from

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-10 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the start > of the region. This meant that would allow copy-propagation even if > the dst wrote to sub_regoffset 4 and our source read from > sub_regoffset 0, which is not c

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-05 Thread Iago Toral
On Tue, 2016-05-03 at 17:28 -0700, Jordan Justen wrote: > On 2016-05-03 05:21:55, Samuel Iglesias Gonsálvez wrote: > > From: Iago Toral Quiroga > > > > We were not accounting for reg_suboffset in the check for the start > > of the region. This meant that would allow copy-propagation even if > > t

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-04 Thread Iago Toral
On Tue, 2016-05-03 at 17:37 -0700, Jason Ekstrand wrote: > > > On Tue, May 3, 2016 at 5:21 AM, Samuel Iglesias Gonsálvez > wrote: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the > start > of the region. This m

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-03 Thread Jason Ekstrand
On Tue, May 3, 2016 at 5:21 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the start > of the region. This meant that would allow copy-propagation even if > the dst wrote to sub_regoffset 4 and

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-03 Thread Jordan Justen
On 2016-05-03 05:21:55, Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > We were not accounting for reg_suboffset in the check for the start > of the region. This meant that would allow copy-propagation even if > the dst wrote to sub_regoffset 4 and our source read from > sub_regof

[Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

2016-05-03 Thread Samuel Iglesias Gonsálvez
From: Iago Toral Quiroga We were not accounting for reg_suboffset in the check for the start of the region. This meant that would allow copy-propagation even if the dst wrote to sub_regoffset 4 and our source read from sub_regoffset 0, which is not correct. This was observed in fp64 code, since t