Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-20 Thread Jason Ekstrand
On Wed, Nov 19, 2014 at 11:58 PM, Iago Toral ito...@igalia.com wrote: On Wed, 2014-11-19 at 11:57 -0800, Jason Ekstrand wrote: A couple of general comments on this patch: 1) The prerequisites should be moved to before the first patch in the series and it should be squashed into the

Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 10:49 -0800, Jason Ekstrand wrote: On Wed, Nov 19, 2014 at 11:58 PM, Iago Toral ito...@igalia.com wrote: On Wed, 2014-11-19 at 11:57 -0800, Jason Ekstrand wrote: A couple of general comments on this patch: 1) The

Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-19 Thread Jason Ekstrand
A couple of general comments on this patch: 1) The prerequisites should be moved to before the first patch in the series and it should be squashed into the patch that introduces the function. There are one or two more patches which also modify it and those should also be squashed in. 2) I

Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-19 Thread Iago Toral
On Wed, 2014-11-19 at 11:57 -0800, Jason Ekstrand wrote: A couple of general comments on this patch: 1) The prerequisites should be moved to before the first patch in the series and it should be squashed into the patch that introduces the function. There are one or two more patches which