Re: [Mesa-dev] [PATCH 08/15] st/mesa: make generic CopyPixels path work with MSAA visuals

2013-06-06 Thread Marek Olšák
On Mon, Jun 3, 2013 at 5:59 PM, Brian Paul brian.e.p...@gmail.com wrote: I seem to recall that this choose a gallium format for a given GL format/type code appears elsewhere in the state tracker (but haven't double-checked). In any case, it would be nicer if this code was moved into a

Re: [Mesa-dev] [PATCH 08/15] st/mesa: make generic CopyPixels path work with MSAA visuals

2013-06-03 Thread Brian Paul
On Sat, Jun 1, 2013 at 8:29 AM, Marek Olšák mar...@gmail.com wrote: We have to use pipe-blit, not resource_copy_region, so that the read buffer is resolved if it's multisampled. I also removed the CPU-based copying, which just did format conversion (obsoleted by the blit). Also, the

[Mesa-dev] [PATCH 08/15] st/mesa: make generic CopyPixels path work with MSAA visuals

2013-06-01 Thread Marek Olšák
We have to use pipe-blit, not resource_copy_region, so that the read buffer is resolved if it's multisampled. I also removed the CPU-based copying, which just did format conversion (obsoleted by the blit). Also, the layer/slice/face of the read buffer is taken into account (this was ignored).