Re: [Mesa-dev] [PATCH 08/18] swr: [rasterizer common] gcc/clang cleanup

2016-05-18 Thread Emil Velikov
On 17 May 2016 at 16:23, Rowley, Timothy O wrote: > It seems to me that we shouldn’t be redefining offsetof at all, but rather > including the appropriate header (cstddef) to make the definition available. > I’m removing this change and including that in swr’s os.h. New title will > read some

Re: [Mesa-dev] [PATCH 08/18] swr: [rasterizer common] gcc/clang cleanup

2016-05-17 Thread Rowley, Timothy O
It seems to me that we shouldn’t be redefining offsetof at all, but rather including the appropriate header (cstddef) to make the definition available. I’m removing this change and including that in swr’s os.h. New title will read something like “swr: [rasterizer common] include cstddef instea

Re: [Mesa-dev] [PATCH 08/18] swr: [rasterizer common] gcc/clang cleanup

2016-05-17 Thread Emil Velikov
Summary should really be "swr: ensure offsetof is defined" or alike ? Why you have it only for linux (defined(FORCE_LINUX) || defined(__linux__) || defined(__gnu_linux__)) though ? -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://li

[Mesa-dev] [PATCH 08/18] swr: [rasterizer common] gcc/clang cleanup

2016-05-16 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 7bfc66f..675fe42 100644 --- a/src/gallium/drivers/swr/rasterizer/common/os.h +++ b/s