Re: [Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-28 Thread Chad Versace
For patches 1 2 3 5 6: Reviewed-by. For patches 4 and 7, with the comments fixed: Reviewed-by. Patch 8, I don't agree with it. Patch 9, I gave an r-b for v2. Patch 10-17: I have to walk away now. I plan to finish review this evening. On 05/24/2013 01:56 PM, Eric Anholt wrote: For a

Re: [Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-28 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: For patches 1 2 3 5 6: Reviewed-by. For patches 4 and 7, with the comments fixed: Reviewed-by. Patch 8, I don't agree with it. Patch 9, I gave an r-b for v2. Patch 10-17: I have to walk away now. I plan to finish review this evening. Sorry,

Re: [Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-26 Thread Paul Berry
On 24 May 2013 13:56, Eric Anholt e...@anholt.net wrote: For a blit-uploaded temporary, it's faster on current hardware to memcpy the data into a linear CPU mapping than to go through the GTT. --- src/mesa/drivers/dri/intel/intel_fbo.c | 2 +-

Re: [Mesa-dev] [PATCH 09/17] intel: Extend the force_y_tiling flag to allow forcing no tiling.

2013-05-24 Thread Ian Romanick
On 05/24/2013 01:56 PM, Eric Anholt wrote: For a blit-uploaded temporary, it's faster on current hardware to memcpy the data into a linear CPU mapping than to go through the GTT. --- src/mesa/drivers/dri/intel/intel_fbo.c | 2 +- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 22