Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-17 Thread Kenneth Graunke
On Tuesday, July 11, 2017 6:02:30 PM PDT Matt Turner wrote: > On Mon, Jul 10, 2017 at 4:05 PM, Connor Abbott wrote: > > On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: > >> On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: > >>> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-11 Thread Connor Abbott
On Tue, Jul 11, 2017 at 6:02 PM, Matt Turner wrote: > On Mon, Jul 10, 2017 at 4:05 PM, Connor Abbott wrote: >> On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: >>> On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > We already

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-11 Thread Matt Turner
On Mon, Jul 10, 2017 at 4:05 PM, Connor Abbott wrote: > On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: >> On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: >>> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: We already had a channel_num system value, which I'm renaming to

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Connor Abbott
On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: > On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: >> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >>> We already had a channel_num system value, which I'm renaming to >>> subgroup_invocation to match the rest of the new system value

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Matt Turner
On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: > On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >> We already had a channel_num system value, which I'm renaming to >> subgroup_invocation to match the rest of the new system values. >> >> Note that while ballotARB(true) will return zeros

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-10 Thread Connor Abbott
On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > We already had a channel_num system value, which I'm renaming to > subgroup_invocation to match the rest of the new system values. > > Note that while ballotARB(true) will return zeros in the high 32-bits on > systems where gl_SubGroupSizeARB <=

[Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-06 Thread Matt Turner
We already had a channel_num system value, which I'm renaming to subgroup_invocation to match the rest of the new system values. Note that while ballotARB(true) will return zeros in the high 32-bits on systems where gl_SubGroupSizeARB <= 32, the gl_SubGroup??MaskARB variables do not consider wheth