Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-24 Thread Tom Stellard
On Tue, Jun 24, 2014 at 08:39:28AM -0400, Jan Vesely wrote: > On Mon, 2014-06-23 at 17:15 +0200, Bruno Jimenez wrote: > > On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > > > The dst pointer needs to be initialized after any calls to > > > compute_memory_grow_pool, as the function might chan

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-24 Thread Jan Vesely
On Mon, 2014-06-23 at 17:15 +0200, Bruno Jimenez wrote: > On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > > The dst pointer needs to be initialized after any calls to > > compute_memory_grow_pool, as the function might change the pool->vbo > > pointer. > > You are completely right. Good c

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-23 Thread Bruno Jimenez
On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > The dst pointer needs to be initialized after any calls to > compute_memory_grow_pool, as the function might change the pool->vbo pointer. You are completely right. Good catch. Reviewed-by: Bruno Jiménez Sorry for any inconvenience this ma

[Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-23 Thread Jan Vesely
The dst pointer needs to be initialized after any calls to compute_memory_grow_pool, as the function might change the pool->vbo pointer. This fixes crashes and assertion failures in two gegl tests. Signed-off-by: Jan Vesely CC: Bruno Jimenez CC: Tom Stellard --- src/gallium/drivers/r600/comp