Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-04 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 04/06/18 01:38, Mauro Rossi wrote: Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo);

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-04 Thread Tapani Pälli
On 06/04/2018 08:50 AM, Jason Ekstrand wrote: Looks good to me.  Tapani (CCd) would know wheter we want EXEC_OBJECT_ASYNC or not.  Either way (not setting EXEC_OBJECT_ASYNC won't hurt), Currently after import we set EXEC_OBJECT_WRITE and remove EXEC_OBJECT_ASYNC (further down the function),

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Jason Ekstrand
Looks good to me. Tapani (CCd) would know wheter we want EXEC_OBJECT_ASYNC or not. Either way (not setting EXEC_OBJECT_ASYNC won't hurt), Reviewed-by: Jason Ekstrand Sorry for the mess and thanks for fixing it! --Jason On Sun, Jun 3, 2018 at 5:38 PM, Mauro Rossi wrote: > Changes to avoid

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi, 2018-06-04 0:31 GMT+02:00 Lionel Landwerlin : > On 03/06/18 21:22, Mauro Rossi wrote: > > Hi there, > > 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin < > lionel.g.landwer...@intel.com>: > >> On 03/06/18 19:41, Mauro Rossi wrote: >> >>> Change to avoid building error: >>> >>> external/mesa/src/

[Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import (v2)

2018-06-03 Thread Mauro Rossi
Changes to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~^ 1 e

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Jason Ekstrand
On June 3, 2018 15:31:11 Lionel Landwerlin wrote: On 03/06/18 21:22, Mauro Rossi wrote: Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin : On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few argu

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Lionel Landwerlin
On 03/06/18 21:22, Mauro Rossi wrote: Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>>: On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error:

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Hi there, 2018-06-03 21:52 GMT+02:00 Lionel Landwerlin : > On 03/06/18 19:41, Mauro Rossi wrote: > >> Change to avoid building error: >> >> external/mesa/src/intel/vulkan/anv_android.c:131:72: >> error: too few arguments to function call, expected 5, have 4 >> result = anv_bo_cache_import(de

Re: [Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Lionel Landwerlin
On 03/06/18 19:41, Mauro Rossi wrote: Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~

[Mesa-dev] [PATCH 1/2] anv/android: Set the BO flags in bo_cache_import

2018-06-03 Thread Mauro Rossi
Change to avoid building error: external/mesa/src/intel/vulkan/anv_android.c:131:72: error: too few arguments to function call, expected 5, have 4 result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo); ~~~^ 1 er