Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

2016-07-28 Thread Jason Ekstrand
On Jul 28, 2016 2:11 PM, "Anuj Phogat" wrote: > > > > On Thu, Jul 28, 2016 at 11:58 AM, Jason Ekstrand wrote: >> >> Please fix gen7 while you're at it. It probably needs the exact same change. With that, > > ​gen7 needs multisample support before we can test sample shading. I > talked to Nanley

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

2016-07-28 Thread Anuj Phogat
On Thu, Jul 28, 2016 at 11:58 AM, Jason Ekstrand wrote: > Please fix gen7 while you're at it. It probably needs the exact same > change. With that, > ​gen7 needs multisample support before we can test sample shading. I talked to Nanley about it and now working on fixing gen7 multisampling. I'll

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

2016-07-28 Thread Jason Ekstrand
Please fix gen7 while you're at it. It probably needs the exact same change. With that, Reviewed-by: Jason Ekstrand On Jul 28, 2016 1:31 PM, "Anuj Phogat" wrote: > We should use the persample_dispatch variable in prog_data. > > Fixes all (~60) the DEQP sample shading tests. Many tests exited

[Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

2016-07-28 Thread Anuj Phogat
We should use the persample_dispatch variable in prog_data. Fixes all (~60) the DEQP sample shading tests. Many tests exited with VK_ERROR_OUT_OF_DEVICE_MEMORY without this patch. V2: Use the shader key bits set in brw_compile_fs (Jason) Cc: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/i