Re: [Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-24 Thread Tapani Pälli
On 08/25/2017 08:08 AM, Jason Ekstrand wrote: On Thu, Aug 24, 2017 at 9:52 PM, Tapani Pälli > wrote: + + vk_foreach_struct(info, pCreateInfo) { Usually, we handle the primary structure directly and then call vk_forea

Re: [Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-24 Thread Jason Ekstrand
On Thu, Aug 24, 2017 at 9:52 PM, Tapani Pälli wrote: > Hi; > > On 08/24/2017 08:36 PM, Jason Ekstrand wrote: > >> On Wed, Aug 23, 2017 at 11:23 PM, Tapani Pälli > > wrote: >> >> Patch adds required functionality for extension to manage a list of >> applicati

Re: [Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-24 Thread Tapani Pälli
Hi; On 08/24/2017 08:36 PM, Jason Ekstrand wrote: On Wed, Aug 23, 2017 at 11:23 PM, Tapani Pälli > wrote: Patch adds required functionality for extension to manage a list of application provided callbacks and handle debug reporting from driver and appl

Re: [Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-24 Thread Jason Ekstrand
On Wed, Aug 23, 2017 at 11:23 PM, Tapani Pälli wrote: > Patch adds required functionality for extension to manage a list of > application provided callbacks and handle debug reporting from driver > and application side. > > Signed-off-by: Tapani Pälli > --- > src/intel/Makefile.sources

Re: [Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-24 Thread Tapani Pälli
I've noticed one missing thing, for VK_ERROR_OUT_OF_HOST_MEMORY situations we would need function to call debug report without actual object (since we failed to allocate it!) by only passing object enum, maybe have a separate vk_memory_error macro for these cases? On 08/24/2017 09:23 AM, Tapan

[Mesa-dev] [PATCH 1/2] anv: implementation of VK_EXT_debug_report extension

2017-08-23 Thread Tapani Pälli
Patch adds required functionality for extension to manage a list of application provided callbacks and handle debug reporting from driver and application side. Signed-off-by: Tapani Pälli --- src/intel/Makefile.sources | 1 + src/intel/vulkan/anv_debug_report.c | 133 +