Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-30 Thread Tom Stellard
On Wed, Jul 24, 2013 at 09:29:49AM -0400, Jonathan Charest wrote: > Here is an updated patch with no line wrapping and respecting 80-column limit > (for my changes). > Hi, I've pushed a modified version of this patch that uses global arguments for constant buffers so it doesn't break r600g, and

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-25 Thread Tom Stellard
Hi Francisco, I just realized that this breaks constant buffers on r600g. The main problem is that there is no way for r600g to return a handle for constant buffers like it can for global buffers. This is also a problem for sampler_views and resources, which are used for images. Do you have any

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-24 Thread Jonathan Charest
Here is an updated patch with no line wrapping and respecting 80-column limit (for my changes). --- .../state_trackers/clover/llvm/invocation.cpp | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cp

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-24 Thread Francisco Jerez
Tom Stellard writes: > On Mon, Jul 22, 2013 at 09:24:12AM -0400, Jonathan Charest wrote: >> To have non-static buffers in local memory, it is necessary to pass them >> as arguments to the kernel. This was almost supported but the address >> space mapping was missing to perform the check (thanks t

Re: [Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-23 Thread Tom Stellard
On Mon, Jul 22, 2013 at 09:24:12AM -0400, Jonathan Charest wrote: > To have non-static buffers in local memory, it is necessary to pass them > as arguments to the kernel. This was almost supported but the address > space mapping was missing to perform the check (thanks to tstellar for > pointing me

[Mesa-dev] [PATCH 1/2] clover: Added missing address space checking of kernel parameters

2013-07-22 Thread Jonathan Charest
To have non-static buffers in local memory, it is necessary to pass them as arguments to the kernel. This was almost supported but the address space mapping was missing to perform the check (thanks to tstellar for pointing me in the right direction). --- .../state_trackers/clover/llvm/invocation.