[Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-06-01 Thread Serge Martin
From: Vedran Miletić Make sure that a struct argument did not get compiled into a pointer type with the byval attribute. If we try to handle the pointer with byval, we end up with the pointer size instead of the struct size. Struct arguments on AMD GPUs will work correctly once Clang gets patche

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-09-19 Thread Vedran Miletić
On 07/28/2016 07:52 AM, Francisco Jerez wrote: > Emil Velikov writes: > >> On 6 June 2016 at 00:02, Vedran Miletić wrote: >>> On 06/04/2016 04:18 AM, Francisco Jerez wrote: Serge Martin writes: > From: Vedran Miletić > > Make sure that a struct argument did not get c

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-09-19 Thread Vedran Miletić
On 09/19/2016 07:08 PM, Vedran Miletić wrote: > On 07/28/2016 07:52 AM, Francisco Jerez wrote: >> Emil Velikov writes: >> >>> On 6 June 2016 at 00:02, Vedran Miletić wrote: On 06/04/2016 04:18 AM, Francisco Jerez wrote: > > Serge Martin writes: > >> From: Vedran Miletić >

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-07-27 Thread Emil Velikov
On 6 June 2016 at 00:02, Vedran Miletić wrote: > On 06/04/2016 04:18 AM, Francisco Jerez wrote: >> >> Serge Martin writes: >> >>> From: Vedran Miletić >>> >>> Make sure that a struct argument did not get compiled into a pointer >>> type with the byval attribute. If we try to handle the pointer w

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-07-27 Thread Francisco Jerez
Emil Velikov writes: > On 6 June 2016 at 00:02, Vedran Miletić wrote: >> On 06/04/2016 04:18 AM, Francisco Jerez wrote: >>> >>> Serge Martin writes: >>> From: Vedran Miletić Make sure that a struct argument did not get compiled into a pointer type with the byval attribute.

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-06-03 Thread Francisco Jerez
Serge Martin writes: > From: Vedran Miletić > > Make sure that a struct argument did not get compiled into a pointer > type with the byval attribute. If we try to handle the pointer with > byval, we end up with the pointer size instead of the struct size. > Ugh, is that a bug in the code below?

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-06-05 Thread Vedran Miletić
On 06/04/2016 04:18 AM, Francisco Jerez wrote: Serge Martin writes: From: Vedran Miletić Make sure that a struct argument did not get compiled into a pointer type with the byval attribute. If we try to handle the pointer with byval, we end up with the pointer size instead of the struct size.