Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-08 Thread Ian Romanick
On 09/06/2015 03:46 PM, Kenneth Graunke wrote: > On Sunday, September 06, 2015 10:06:38 PM Marek Olšák wrote: >> On Sun, Sep 6, 2015 at 8:38 PM, Emil Velikov >> wrote: >>> On 3 September 2015 at 20:33, Ilia Mirkin wrote: On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák wrote: > > 2) Usi

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-06 Thread Kenneth Graunke
On Sunday, September 06, 2015 10:06:38 PM Marek Olšák wrote: > On Sun, Sep 6, 2015 at 8:38 PM, Emil Velikov wrote: > > On 3 September 2015 at 20:33, Ilia Mirkin wrote: > >> On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák wrote: > >>> > >>> 2) Using LIBGL_DRIVERS_PATH won't use the correct drirc file

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-06 Thread Marek Olšák
On Sun, Sep 6, 2015 at 8:38 PM, Emil Velikov wrote: > On 3 September 2015 at 20:33, Ilia Mirkin wrote: >> On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák wrote: >>> >>> 2) Using LIBGL_DRIVERS_PATH won't use the correct drirc file. The only >>> remaining solution to that is to kill LIBGL_DRIVERS_PATH

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-06 Thread Emil Velikov
On 3 September 2015 at 20:33, Ilia Mirkin wrote: > On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák wrote: >> It looks like the comments have mostly been negative. Fwiw I'm in favour of the series. They provide a sane, up-to date version of the config. Sort of like how nowadays xserver does not requir

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-03 Thread Ilia Mirkin
On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák wrote: > It looks like the comments have mostly been negative. If I get any > other bugs related to this, I'll have to resort to using setenv in the > driver to get the behavior that should be the default. > > There are 2 unresolved issues though: > > 1)

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-03 Thread Marek Olšák
It looks like the comments have mostly been negative. If I get any other bugs related to this, I'll have to resort to using setenv in the driver to get the behavior that should be the default. There are 2 unresolved issues though: 1) The location is hardcoded to /etc/drirc in xmlconfig.c. Install

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 02:38:38 PM Matt Turner wrote: > On Wed, Sep 2, 2015 at 1:43 PM, Kenneth Graunke wrote: > > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: > >> From: Marek Olšák > >> > >> People are having issues with apps because drirc wasn't installed > >> into

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Marek Olšák
On Wed, Sep 2, 2015 at 10:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >> --- >> src/mesa/drivers/dri/common/Makefile.

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Matt Turner
On Wed, Sep 2, 2015 at 1:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >> --- >> src/mesa/drivers/dri/common/Makefile.a

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 04:47:13 PM Ilia Mirkin wrote: > On Wed, Sep 2, 2015 at 4:43 PM, Kenneth Graunke wrote: > > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: > >> From: Marek Olšák > >> > >> People are having issues with apps because drirc wasn't installed > >> into

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 4:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >> --- >> src/mesa/drivers/dri/common/Makefile.a

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: > From: Marek Olšák > > People are having issues with apps because drirc wasn't installed > into /etc. I've lost patience. > --- > src/mesa/drivers/dri/common/Makefile.am | 4 +- > src/mesa/drivers/dri/common/Makefile.sources

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Marek Olšák
On Wed, Sep 2, 2015 at 5:57 PM, Ian Romanick wrote: > For some reason the original patches and Ilia's response never showed up > in my inbox. > > So... how does one have a Mesa driver that doesn't enable any work > arounds? While this may work around the problem, it doesn't feel like > the right

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Emil Velikov
On 2 September 2015 at 16:57, Ian Romanick wrote: > For some reason the original patches and Ilia's response never showed up > in my inbox. > > So... how does one have a Mesa driver that doesn't enable any work > arounds? Very good point, although I believe this limitation already exists with /etc

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Ian Romanick
For some reason the original patches and Ilia's response never showed up in my inbox. So... how does one have a Mesa driver that doesn't enable any work arounds? While this may work around the problem, it doesn't feel like the right solution. On 09/02/2015 06:55 AM, Iago Toral wrote: > Both patc

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Iago Toral
Both patches do what they advertise and seem to work, so they are Reviewed-by: Iago Toral Quiroga That said, I imagine that probably you want to get at least a few ACKs from other devs, like Illia did, to make sure that your changes have enough support. Iago On Wed, 2015-09-02 at 02:26 +0200,

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-01 Thread Ilia Mirkin
I was actually going to suggest loading from the sysconfig dir instead of /etc a while back, but this works for me too. I haven't looked over the details, but the idea of this series is Acked-by: Ilia Mirkin On Tue, Sep 1, 2015 at 8:26 PM, Marek Olšák wrote: > From: Marek Olšák > > People are

[Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-01 Thread Marek Olšák
From: Marek Olšák People are having issues with apps because drirc wasn't installed into /etc. I've lost patience. --- src/mesa/drivers/dri/common/Makefile.am | 4 +- src/mesa/drivers/dri/common/Makefile.sources | 3 +- src/mesa/drivers/dri/common/drirc| 84