Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-02 Thread Kenneth Graunke
On Tuesday, September 01, 2015 07:03:58 PM Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 6:53 PM, Matt Turner wrote: > > On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner wrote: > >> --- > >> I checked the uses of count_attribute_slots() and it looks like they're > >> expecting this already, but these tw

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-01 Thread Dave Airlie
On 2 September 2015 at 08:57, Matt Turner wrote: > --- > I checked the uses of count_attribute_slots() and it looks like they're > expecting this already, but these two patches definitely need testing on > a driver that supports fp64. > Don't think so, As Ilia said they can count as storage for 2

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 6:53 PM, Matt Turner wrote: > On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner wrote: >> --- >> I checked the uses of count_attribute_slots() and it looks like they're >> expecting this already, but these two patches definitely need testing on >> a driver that supports fp64. > >

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-01 Thread Matt Turner
On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner wrote: > --- > I checked the uses of count_attribute_slots() and it looks like they're > expecting this already, but these two patches definitely need testing on > a driver that supports fp64. Whoops, assuming things go well this should also be Cc'd to

[Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-01 Thread Matt Turner
--- I checked the uses of count_attribute_slots() and it looks like they're expecting this already, but these two patches definitely need testing on a driver that supports fp64. src/glsl/glsl_types.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_types.cpp