Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-08-11 Thread Matt Turner
On Mon, Aug 11, 2014 at 7:39 PM, Anuj Phogat wrote: > Matt, should I consider both of these r-b you? Yes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-08-11 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 3:08 PM, Anuj Phogat wrote: > On Tue, Jul 29, 2014 at 7:18 AM, Matt Turner wrote: > > > > On Mon, Jul 28, 2014 at 8:47 PM, Anuj Phogat > wrote: > > > Fixes Khronos GLES3 CTS test: > > > dynamic_expression_array_access_vertex > > > > > > Cc: > > > Signed-off-by: Anuj Pho

Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-07-29 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 7:18 AM, Matt Turner wrote: > > On Mon, Jul 28, 2014 at 8:47 PM, Anuj Phogat wrote: > > Fixes Khronos GLES3 CTS test: > > dynamic_expression_array_access_vertex > > > > Cc: > > Signed-off-by: Anuj Phogat > > --- > > I don't have a test case though it might be useful to a

Re: [Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-07-29 Thread Matt Turner
On Mon, Jul 28, 2014 at 8:47 PM, Anuj Phogat wrote: > Fixes Khronos GLES3 CTS test: > dynamic_expression_array_access_vertex > > Cc: > Signed-off-by: Anuj Phogat > --- > I don't have a test case though it might be useful to also include > the check for VS_OPCODE_URB_WRITE here? > > src/mesa/dri

[Mesa-dev] [PATCH 1/2] i965: Bail on vec4 copy propagation for scratch writes with source modifiers

2014-07-28 Thread Anuj Phogat
Fixes Khronos GLES3 CTS test: dynamic_expression_array_access_vertex Cc: Signed-off-by: Anuj Phogat --- I don't have a test case though it might be useful to also include the check for VS_OPCODE_URB_WRITE here? src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 4 1 file changed, 4