Re: [Mesa-dev] [PATCH 1/2] i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

2014-06-11 Thread Iago Toral
Urgh, sorry about that :-( I'll be more careful when manipulating the state flags next time. Iago On Tue, 2014-06-10 at 20:12 -0700, Kenneth Graunke wrote: In commit dc2d3a7f5c217a7cee92380fbf503924a9591bea, Iago accidentally moved fire_fb_write() above the brw_pop_insn_state(), which caused

Re: [Mesa-dev] [PATCH 1/2] i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

2014-06-11 Thread Kenneth Graunke
On Wednesday, June 11, 2014 08:00:13 AM Iago Toral wrote: Urgh, sorry about that :-( I'll be more careful when manipulating the state flags next time. Iago No worries! This kind of stuff happens, and I didn't catch it either. It's just part of development. This is one reason I've been

[Mesa-dev] [PATCH 1/2] i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

2014-06-10 Thread Kenneth Graunke
In commit dc2d3a7f5c217a7cee92380fbf503924a9591bea, Iago accidentally moved fire_fb_write() above the brw_pop_insn_state(), which caused the SEND to lose its predication and change from WE_normal to WE_all. Haswell uses predicated SENDs for discards, so this broke Piglit's tests for discards. We

Re: [Mesa-dev] [PATCH 1/2] i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

2014-06-10 Thread Matt Turner
Both are Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev