Re: [Mesa-dev] [PATCH 1/2] intel: Move finish_batch() call before MI_BATCH_BUFFER_END and padding.

2012-08-12 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On Gen4+, brw_finish_batch() calls brw_emit_query_end(), which emits some extra PIPE_CONTROLs to capture the current occlusion query data. Unfortunately, it was being called *after* _intel_batchbuffer_flush added the MI_BATCH_BUFFER_END, meaning

[Mesa-dev] [PATCH 1/2] intel: Move finish_batch() call before MI_BATCH_BUFFER_END and padding.

2012-08-10 Thread Kenneth Graunke
On Gen4+, brw_finish_batch() calls brw_emit_query_end(), which emits some extra PIPE_CONTROLs to capture the current occlusion query data. Unfortunately, it was being called *after* _intel_batchbuffer_flush added the MI_BATCH_BUFFER_END, meaning those PIPE_CONTROLs didn't get inside the batch.