Re: [Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-02-06 Thread Frank Henigman
On Mon, Jan 28, 2013 at 9:50 PM, Ian Romanick wrote: > On 01/28/2013 05:06 PM, Frank Henigman wrote: > >> An assertion in fs_visitor::remove_dead_**constants() would fail on >> code like this, which accesses a non-existent uniform: >>uniform vec u[1]; >>... >>a += u[0] + u[1]; >> Shad

Re: [Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-01-28 Thread Ian Romanick
On 01/28/2013 05:06 PM, Frank Henigman wrote: An assertion in fs_visitor::remove_dead_constants() would fail on code like this, which accesses a non-existent uniform: uniform vec u[1]; ... a += u[0] + u[1]; Shader code is checked for that error, but apparently only before transformations

[Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-01-28 Thread Frank Henigman
An assertion in fs_visitor::remove_dead_constants() would fail on code like this, which accesses a non-existent uniform: uniform vec u[1]; ... a += u[0] + u[1]; Shader code is checked for that error, but apparently only before transformations like loop unrolling. So the following code would