Re: [Mesa-dev] [PATCH 1/2] loader: refactor duplicated code into loader util lib

2014-01-10 Thread Chad Versace
On Fri, Jan 10, 2014 at 08:14:19AM -0500, Rob Clark wrote: > On Thu, Jan 9, 2014 at 10:36 PM, Eric Anholt wrote: > > Rob Clark writes: > > > >> From: Rob Clark > >> static int > >> droid_open_device(void) > >> { > >> @@ -773,7 +672,7 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay >

Re: [Mesa-dev] [PATCH 1/2] loader: refactor duplicated code into loader util lib

2014-01-10 Thread Rob Clark
On Thu, Jan 9, 2014 at 10:36 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> All the various window system integration layers duplicate roughly the >> same code for figuring out device and driver name, pci-id's, etc. Which >> is sad. So extract it out into a loader util l

Re: [Mesa-dev] [PATCH 1/2] loader: refactor duplicated code into loader util lib

2014-01-09 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > All the various window system integration layers duplicate roughly the > same code for figuring out device and driver name, pci-id's, etc. Which > is sad. So extract it out into a loader util lib. Thanks for tackling this. It had been (low) on my list