Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Laura Ekstrand
On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: > Different errors for type mismatches, size mismatches and matrix/ > non-matrix mismatches. Use a common format of "uniformName"@location > in the messags. > --- > src/mesa/main/uniform_query.cpp | 69 > ++--

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Kenneth Graunke
On Thursday, March 19, 2015 12:55:48 PM Brian Paul wrote: > On 03/19/2015 12:03 PM, Ian Romanick wrote: > > On 03/19/2015 07:56 AM, Brian Paul wrote: > >> On 03/19/2015 08:53 AM, Brian Paul wrote: > >>> Different errors for type mismatches, size mismatches and matrix/ > >>> non-matrix mismatches.

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
On 03/19/2015 12:03 PM, Ian Romanick wrote: On 03/19/2015 07:56 AM, Brian Paul wrote: On 03/19/2015 08:53 AM, Brian Paul wrote: Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Ian Romanick
On 03/19/2015 07:56 AM, Brian Paul wrote: > On 03/19/2015 08:53 AM, Brian Paul wrote: >> Different errors for type mismatches, size mismatches and matrix/ >> non-matrix mismatches. Use a common format of "uniformName"@location >> in the messags. >> --- >> src/mesa/main/uniform_query.cpp | 69 >>

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
On 03/19/2015 08:53 AM, Brian Paul wrote: Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa/main/uniform_query.cpp | 69 ++--- 1 file changed,

[Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

2015-03-19 Thread Brian Paul
Different errors for type mismatches, size mismatches and matrix/ non-matrix mismatches. Use a common format of "uniformName"@location in the messags. --- src/mesa/main/uniform_query.cpp | 69 ++--- 1 file changed, 65 insertions(+), 4 deletions(-) diff --git a