[Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-23 Thread Ilia Mirkin
This matches the behavior of most other drivers, including nouveau. Signed-off-by: Ilia Mirkin --- Untested. This also leaves RCP and RSQ with the clamped variants. I suspect this is wrong, but seems unrelated to multiplication per se. src/gallium/drivers/r600/r600_shader.c | 36 ++

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Matteo Bruni
2017-01-24 3:18 GMT+01:00 Ilia Mirkin : > This matches the behavior of most other drivers, including nouveau. Doesn't this break all the applications depending on d3d9 NaN behavior (including, but not limited to, d3d9 games in Wine) on r600g? If I got this right, flipping around the two patches i

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Ilia Mirkin
On Tue, Jan 24, 2017 at 1:11 PM, Matteo Bruni wrote: > 2017-01-24 3:18 GMT+01:00 Ilia Mirkin : >> This matches the behavior of most other drivers, including nouveau. > > Doesn't this break all the applications depending on d3d9 NaN behavior > (including, but not limited to, d3d9 games in Wine) on

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Matteo Bruni
2017-01-24 19:15 GMT+01:00 Ilia Mirkin : > On Tue, Jan 24, 2017 at 1:11 PM, Matteo Bruni > wrote: >> 2017-01-24 3:18 GMT+01:00 Ilia Mirkin : >>> This matches the behavior of most other drivers, including nouveau. >> >> Doesn't this break all the applications depending on d3d9 NaN behavior >> (inc

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Ilia Mirkin
On Tue, Jan 24, 2017 at 2:11 PM, Matteo Bruni wrote: > 2017-01-24 19:15 GMT+01:00 Ilia Mirkin : >> On Tue, Jan 24, 2017 at 1:11 PM, Matteo Bruni >> wrote: >>> 2017-01-24 3:18 GMT+01:00 Ilia Mirkin : This matches the behavior of most other drivers, including nouveau. >>> >>> Doesn't this bre

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Ilia Mirkin
On Tue, Jan 24, 2017 at 2:11 PM, Matteo Bruni wrote: > That doesn't help Wine or any "native" OpenGL application which > happens to depend on the old behavior. Oh, and another note on that - I *do* think it helps those applications. Because now they will no longer inexplicably work on r600 and no

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Axel Davy
On 24/01/2017 20:11, Matteo Bruni wrote: 2017-01-24 19:15 GMT+01:00 Ilia Mirkin : On Tue, Jan 24, 2017 at 1:11 PM, Matteo Bruni wrote: 2017-01-24 3:18 GMT+01:00 Ilia Mirkin : This matches the behavior of most other drivers, including nouveau. Doesn't this break all the applications depending