Re: [Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

2017-04-10 Thread Bas Nieuwenhuizen
) On Mon, Apr 10, 2017 at 4:54 AM, Edward O'Callaghan wrote: > One trivial comment but otherwise 1&2 are, > Reviewed-by: Edward O'Callaghan > > On 04/10/2017 09:34 AM, Bas Nieuwenhuizen wrote: >> Adds a shader for writing occlusion query results to a buffer, as the >> CP packet isn't support on

Re: [Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

2017-04-09 Thread Edward O'Callaghan
One trivial comment but otherwise 1&2 are, Reviewed-by: Edward O'Callaghan On 04/10/2017 09:34 AM, Bas Nieuwenhuizen wrote: > Adds a shader for writing occlusion query results to a buffer, as the > CP packet isn't support on SI or secondary buffers, and doesn't handle > the availability bit (or p

[Mesa-dev] [PATCH 1/2] radv: Add occlusion query shader.

2017-04-09 Thread Bas Nieuwenhuizen
Adds a shader for writing occlusion query results to a buffer, as the CP packet isn't support on SI or secondary buffers, and doesn't handle the availability bit (or partial results) nor truncation to 32-bit. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta.c| 7 + src/amd/vul