Re: [Mesa-dev] [PATCH 1/2] radv: fix setting CB_DCC_BASE if the base level doesn't enable DCC

2019-06-25 Thread Samuel Pitoiset
On 6/25/19 1:38 AM, Bas Nieuwenhuizen wrote: why? We should be regulating enabling it with S_028C70_DCC_ENABLE. Correct. Please ignore this patch, it's not wrong, just useless. On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset wrote: CB_DCC_BASE should be 0 if no DCC. Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 1/2] radv: fix setting CB_DCC_BASE if the base level doesn't enable DCC

2019-06-24 Thread Bas Nieuwenhuizen
why? We should be regulating enabling it with S_028C70_DCC_ENABLE. On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset wrote: > > CB_DCC_BASE should be 0 if no DCC. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 15 --- > 1 file changed, 8 insertions(+), 7 de

[Mesa-dev] [PATCH 1/2] radv: fix setting CB_DCC_BASE if the base level doesn't enable DCC

2019-06-24 Thread Samuel Pitoiset
CB_DCC_BASE should be 0 if no DCC. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 26b31cff9f1..dc5de683050 100644 --- a/src/amd/v