Re: [Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

2011-10-12 Thread Brian Paul
On 10/11/2011 09:57 PM, Eric Anholt wrote: On Mon, 10 Oct 2011 18:10:59 -0700, Chad Versace wrote: For glReadPixels, the user supplied pixels have format GL_UNSIGNED_INT_24_8. But, when the depthstencil buffer's format was MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reorderin

Re: [Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

2011-10-11 Thread Eric Anholt
On Mon, 10 Oct 2011 18:10:59 -0700, Chad Versace wrote: > For glReadPixels, the user supplied pixels have format > GL_UNSIGNED_INT_24_8. But, when the depthstencil buffer's format was > MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reordering > the depth and stencil bits. To fix t

Re: [Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

2011-10-10 Thread Brian Paul
On Mon, Oct 10, 2011 at 7:10 PM, Chad Versace wrote: > For glReadPixels, the user supplied pixels have format > GL_UNSIGNED_INT_24_8.  But, when the depthstencil buffer's format was > MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reordering > the depth and stencil bits. To fix this

[Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

2011-10-10 Thread Chad Versace
For glReadPixels, the user supplied pixels have format GL_UNSIGNED_INT_24_8. But, when the depthstencil buffer's format was MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reordering the depth and stencil bits. To fix this, this patch just skips the fastpath when the format is not ME