Re: [Mesa-dev] [PATCH 1/2] tgsi: collect texture sampler target info in tgsi_scan_shader()

2016-03-29 Thread Roland Scheidegger
Am 29.03.2016 um 22:39 schrieb Jose Fonseca: > On 29/03/16 21:22, Roland Scheidegger wrote: >> I actually think "is_tex" is a bit confusing (because there's lots of >> other parts in the code where we don't really distinguish between >> "texture" and "sample" class of instructions and refer to

Re: [Mesa-dev] [PATCH 1/2] tgsi: collect texture sampler target info in tgsi_scan_shader()

2016-03-29 Thread Brian Paul
On 03/29/2016 02:39 PM, Jose Fonseca wrote: On 29/03/16 21:22, Roland Scheidegger wrote: I actually think "is_tex" is a bit confusing (because there's lots of other parts in the code where we don't really distinguish between "texture" and "sample" class of instructions and refer to them by the

Re: [Mesa-dev] [PATCH 1/2] tgsi: collect texture sampler target info in tgsi_scan_shader()

2016-03-29 Thread Jose Fonseca
On 29/03/16 21:22, Roland Scheidegger wrote: I actually think "is_tex" is a bit confusing (because there's lots of other parts in the code where we don't really distinguish between "texture" and "sample" class of instructions and refer to them by the same name), but it certainly should work here

Re: [Mesa-dev] [PATCH 1/2] tgsi: collect texture sampler target info in tgsi_scan_shader()

2016-03-29 Thread Roland Scheidegger
I actually think "is_tex" is a bit confusing (because there's lots of other parts in the code where we don't really distinguish between "texture" and "sample" class of instructions and refer to them by the same name), but it certainly should work here (I think originally it actually meant there'd

[Mesa-dev] [PATCH 1/2] tgsi: collect texture sampler target info in tgsi_scan_shader()

2016-03-29 Thread Brian Paul
Texture sample instructions specify a sampler unit and texture target such as "1D", "2D", "CUBE", etc. Sampler view declarations also specify the sampler unit and texture target. This patch checks that the texture instructions agree with the declarations and collects the texture target type for