Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-30 Thread Thomas Helland
2017-08-29 7:25 GMT+02:00 Thomas Helland : > 2017-08-28 11:47 GMT+02:00 Nicolai Hähnle : >> On 28.08.2017 11:13, Nicolai Hähnle wrote: >>> >>> On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: > >

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-28 Thread Thomas Helland
2017-08-28 11:47 GMT+02:00 Nicolai Hähnle : > On 28.08.2017 11:13, Nicolai Hähnle wrote: >> >> On 28.08.2017 03:51, Timothy Arceri wrote: >>> >>> On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-28 Thread Nicolai Hähnle
On 28.08.2017 11:13, Nicolai Hähnle wrote: On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-28 Thread Nicolai Hähnle
On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification of Vladislav's original implementation.

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-27 Thread Timothy Arceri
On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification of Vladislav's original implementation. Would be nice to see a performance comparison

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-26 Thread Thomas Helland
Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification of Vladislav's original implementation. Would be nice to see a performance comparison though. I'll try to get some numbers up for

[Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-26 Thread Nicolai Hähnle
From: Nicolai Hähnle For building long strings by successive append operations. --- src/util/Makefile.sources | 2 + src/util/stringbuf.c | 185 ++ src/util/stringbuf.h | 97 3 files