Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Timothy Arceri
On 18/4/19 4:39 pm, Samuel Pitoiset wrote: On 4/18/19 8:38 AM, Samuel Pitoiset wrote: On 4/18/19 8:34 AM, Timothy Arceri wrote: On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to say

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Samuel Pitoiset
On 4/18/19 8:39 AM, Samuel Pitoiset wrote: On 4/18/19 8:38 AM, Samuel Pitoiset wrote: On 4/18/19 8:34 AM, Timothy Arceri wrote: On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Samuel Pitoiset
On 4/18/19 8:38 AM, Samuel Pitoiset wrote: On 4/18/19 8:34 AM, Timothy Arceri wrote: On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to say in the commit messages: This first patch

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Samuel Pitoiset
On 4/18/19 8:34 AM, Timothy Arceri wrote: On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to say in the commit messages: This first patch in this series caused a piglit regression with

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Timothy Arceri
On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to say in the commit messages: This first patch in this series caused a piglit regression with radeonsi NIR on my VEGA64 with LLVM 9.

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Samuel Pitoiset
On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? Well, there is something really strange with RadeonSI NIR then. On 18/4/19 4:15 pm, Timothy Arceri wrote: This reverts commit 9cf55b022dfa43f8fe3163edeb87a1c25ebf5a16. This first patch in

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Timothy Arceri
Meant to add this was tested on LLVM 9. On 18/4/19 4:15 pm, Timothy Arceri wrote: This reverts commit 9cf55b022dfa43f8fe3163edeb87a1c25ebf5a16. This first patch in this series caused a piglit regression with radeonsi NIR on my VEGA64.

[Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Timothy Arceri
This reverts commit 9cf55b022dfa43f8fe3163edeb87a1c25ebf5a16. This first patch in this series caused a piglit regression with radeonsi NIR on my VEGA64. tests/spec/arb_shader_storage_buffer_object/execution/ssbo-atomicAdd-int.shader_test --- src/amd/vulkan/radv_device.c | 10 --