Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-04 Thread Stéphane Marchesin
On Wed, Sep 4, 2013 at 2:33 PM, Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > > > > On Wed, Sep 4, 2013 at 12:46 PM, Zack Rusin wrote: > >> Hi, Stéphane. >> >> No we should not revert to the old behavior. The old behavior was >> incorrect. Consider this: >> >> -- setup state that dr

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-04 Thread Stéphane Marchesin
On Wed, Sep 4, 2013 at 12:46 PM, Zack Rusin wrote: > Hi, Stéphane. > > No we should not revert to the old behavior. The old behavior was > incorrect. Consider this: > > -- setup state that draws a wireframe -> draw should inject frontface > -- the driver needs to be able to find the injected wire

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-04 Thread Zack Rusin
Hi, Stéphane. No we should not revert to the old behavior. The old behavior was incorrect. Consider this: -- setup state that draws a wireframe -> draw should inject frontface -- the driver needs to be able to find the injected wireframe output -- draw -- setup state the draws solid fill wi

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-04 Thread Stéphane Marchesin
On Tue, Sep 3, 2013 at 9:38 PM, Matt Turner wrote: > On Tue, Sep 3, 2013 at 8:20 PM, Stéphane Marchesin > wrote: > > Hi Zack, > > > > This change regresses a bunch of point sprite piglit tests on i915g. > Should > > we revert back to the old behaviour? As far as I can see, it was correct > (it >

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-03 Thread Matt Turner
On Tue, Sep 3, 2013 at 8:20 PM, Stéphane Marchesin wrote: > Hi Zack, > > This change regresses a bunch of point sprite piglit tests on i915g. Should > we revert back to the old behaviour? As far as I can see, it was correct (it > was keeping the attributes in case another stage is using them). > >

Re: [Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-09-03 Thread Stéphane Marchesin
Hi Zack, This change regresses a bunch of point sprite piglit tests on i915g. Should we revert back to the old behaviour? As far as I can see, it was correct (it was keeping the attributes in case another stage is using them). Stéphane On Thu, Aug 8, 2013 at 12:46 PM, Zack Rusin wrote: > Bef

[Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-08-08 Thread Zack Rusin
Before inserting new front face and prim id outputs cleanup the old extra outputs, otherwise our cache will use previous output slots which will break as soon as outputs of the current shader don't match the last. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_context.c |1 +