Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

Before my patch, gcc warned about: src/gallium/drivers/freedreno/a2xx/fd2_screen.c:64:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] The change suggested: (fd2_pipe2surface(format) != (enum a2xx_sq_surfaceformat)~0)) { makes both compiler

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jul 28, 2016 at 6:55 PM, Rob Clark wrote: > On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: >> On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli >> wrote: >>> --- >>> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: > On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli > wrote: >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli wrote: > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c >

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

I've pushed 'em, thx On Wed, Jul 13, 2016 at 1:03 PM, Francesco Ansanelli wrote: > Yes, please. > > Cheers, > Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jun 30, 2016 at 1:16 PM, Francesco Ansanelli wrote: > this looks like the right thing to do.. r-b for the series. Do you need me to push? BR, -R > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

Yes, please. Cheers, Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

--- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index c2baa6f..fe4849b 100644 ---