Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-21 Thread Ian Romanick
On 09/20/2017 09:15 PM, Timothy Arceri wrote: > Fix sent: > > https://lists.freedesktop.org/archives/mesa-dev/2017-September/170304.html Ugh... which I already deleted from my inbox due to the tag. :( I'll bet this fixes https://bugs.freedesktop.org/show_bug.cgi?id=102910. That patch is

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-20 Thread Timothy Arceri
Fix sent: https://lists.freedesktop.org/archives/mesa-dev/2017-September/170304.html On 21/09/17 11:09, Timothy Arceri wrote: Hi Ian, This series causes massive memory use in the glsl_to_tgsi pass for gallium drivers. For example with the following test: ./bin/shader_runner_gles3

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-20 Thread Timothy Arceri
Hi Ian, This series causes massive memory use in the glsl_to_tgsi pass for gallium drivers. For example with the following test: ./bin/shader_runner_gles3 tests/spec/glsl-es-3.00/execution/varying-struct-copy-return-vs.shader_test -auto I'm not sure whats going on yet because it crashes

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-13 Thread tournier.elie
On 13 September 2017 at 13:13, Alejandro Piñeiro wrote: > Series: > Reviewed-by: Alejandro Piñeiro FWIW Reviewed-by: Elie Tournier > > On 12/09/17 18:41, Ian Romanick wrote: >> From: Ian Romanick

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-13 Thread Alejandro Piñeiro
Series: Reviewed-by: Alejandro Piñeiro On 12/09/17 18:41, Ian Romanick wrote: > From: Ian Romanick > > glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, > _mesa_glsl_parse_state*, const ast_type_qualifier&, const >

[Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-12 Thread Ian Romanick
From: Ian Romanick glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, _mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’: glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter]