Re: [Mesa-dev] [PATCH 1/3] i965/vec4/gs: restore the uniform values which was overwritten by failed vec4_gs_visitor execution

2017-05-17 Thread Samuel Iglesias Gonsálvez
Kind reminder that patches 1 and 3 are still unreviewed. Sam On Fri, 2017-05-05 at 12:38 +0200, Samuel Iglesias Gonsálvez wrote: > We are going to add a packing feature to reduce the usage of the push > constant buffer. One of the consequences is that 'nr_params' would be > modified by

[Mesa-dev] [PATCH 1/3] i965/vec4/gs: restore the uniform values which was overwritten by failed vec4_gs_visitor execution

2017-05-05 Thread Samuel Iglesias Gonsálvez
We are going to add a packing feature to reduce the usage of the push constant buffer. One of the consequences is that 'nr_params' would be modified by vec4_visitor's run call, so we need to restore it if one of them failed before executing the fallback ones. Same thing happens to the uniforms