Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-10 Thread Xu, Randy
Jerez Subject: Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP. On Wed, Oct 5, 2016 at 9:11 PM, Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote: On Wed, Oct 5, 2016 at 7:05 PM, Xu, Randy mailto:randy...@intel.com>> wrote: Hi, Jason Do

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-06 Thread Jason Ekstrand
ce negative_x for example, the total offset in bo is >> 144(y)*64(x)*4(bpp) = 36864. >> >> It’s TILING_Y buffer, as the y (144) is not 32 aligned (mask_y = 31 from >> intel_region_get_tile_masks), the total bo offset is divided into two >> parts: 36864 = 32768 (offse

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-05 Thread Jason Ekstrand
> > > > > > *From:* Jason Ekstrand [mailto:ja...@jlekstrand.net] > *Sent:* Thursday, October 6, 2016 1:58 AM > *To:* Xu, Randy > *Cc:* Palli, Tapani ; > mesa-dev@lists.freedesktop.org > > *Subject:* Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-05 Thread Xu, Randy
r 4, 2016 11:59 PM To: Palli, Tapani mailto:tapani.pa...@intel.com>> Cc: Xu, Randy mailto:randy...@intel.com>>; mesa-dev@lists.freedesktop.org<mailto:mesa-dev@lists.freedesktop.org>; x...@freedesktop.org<mailto:x...@freedesktop.org> Subject: Re: [Mesa-dev] [PATCH 1/3] i96

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-05 Thread Jason Ekstrand
gt; Thanks, > > Randy > > > > > > > > > > *From:* Jason Ekstrand [mailto:ja...@jlekstrand.net] > *Sent:* Tuesday, October 4, 2016 11:59 PM > *To:* Palli, Tapani > *Cc:* Xu, Randy ; mesa-dev@lists.freedesktop.org; > x...@freedesktop.org > *Subject:*

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Xu, Randy
Randy ; mesa-dev@lists.freedesktop.org; x...@freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP. On Tue, Oct 4, 2016 at 8:55 AM, Tapani Pälli mailto:tapani.pa...@intel.com>> wrote: On 10/04/2016 06:09 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Jason Ekstrand
On Tue, Oct 4, 2016 at 8:55 AM, Tapani Pälli wrote: > On 10/04/2016 06:09 PM, Jason Ekstrand wrote: > > On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy wrote: > >> Add the miptree level/slice x/y_offset when count the surface offset >> in brw_emit_surface_state. The surface offset has two parts, one

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Tapani Pälli
On 10/04/2016 06:09 PM, Jason Ekstrand wrote: On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy > wrote: Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Jason Ekstrand
On Thu, Sep 29, 2016 at 11:27 PM, Xu,Randy wrote: > Add the miptree level/slice x/y_offset when count the surface offset > in brw_emit_surface_state. The surface offset has two parts, one is > from mt->offset, which should be 32 aligned in width/height for tiled > buffer; another is from mt->leve

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-04 Thread Tapani Pälli
Hi; It seems Randy's original mail never ended up to the list (?) but patch is available for review in Patchwork: https://patchwork.freedesktop.org/patch/113278/ Thanks; On 09/30/2016 09:41 AM, Tapani Pälli wrote: I have only 6 failures in that set currently, but this patch fixes all of the

[Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-02 Thread Xu,Randy
Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which should be 32 aligned in width/height for tiled buffer; another is from mt->level[current_level].slice[current_slice]. x/y_offset. This fix

[Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-02 Thread Xu,Randy
Add the miptree level/slice x/y_offset when count the surface offset in brw_emit_surface_state. The surface offset has two parts, one is from mt->offset, which should be 32 aligned in width/height for tiled buffer; another is from mt->level[current_level].slice[current_slice]. x/y_offset. This fix

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-09-29 Thread Tapani Pälli
I have only 6 failures in that set currently, but this patch fixes all of them. Reason seems to be that with these cases we never up calling intel_miptree_get_tile_offsets and therefore use uninitialized values for tile_x and tile_y. Tested-by: Tapani Pälli On 09/30/2016 08:56 AM, Xu,Randy w