Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:51, Paul Berry wrote: > On 3 January 2012 18:16, Eric Anholt wrote: > >> >> This series is Reviewed-by: Eric Anholt >> >> With this and the fix I have for glGetTransformFeedbackVarying(), I >> think we should be passing the oglc tests, except for one more case: >> They try

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:56, Eric Anholt wrote: > On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry > wrote: > > On 3 January 2012 18:16, Eric Anholt wrote: > > > > > > > > This series is Reviewed-by: Eric Anholt > > > > > > With this and the fix I have for glGetTransformFeedbackVarying(), I > > > thi

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry wrote: > On 3 January 2012 18:16, Eric Anholt wrote: > > > > > This series is Reviewed-by: Eric Anholt > > > > With this and the fix I have for glGetTransformFeedbackVarying(), I > > think we should be passing the oglc tests, except for one more cas

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:16, Eric Anholt wrote: > > This series is Reviewed-by: Eric Anholt > > With this and the fix I have for glGetTransformFeedbackVarying(), I > think we should be passing the oglc tests, except for one more case: > They try to ask for whole arrays to be fed back, without [] in

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
This series is Reviewed-by: Eric Anholt With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be passing the oglc tests, except for one more case: They try to ask for whole arrays to be fed back, without [] in the declaration. The clearest text I could find on this

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Ian Romanick
On 01/02/2012 09:37 PM, Paul Berry wrote: Patches 1/3 and 3/3 are Reviewed-by: Ian Romanick I had a question about 2/3. --- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/ma

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Brian Paul
On 01/02/2012 10:37 PM, Paul Berry wrote: --- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b71b44b..52a9bd4 100644 --- a/src/

[Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-02 Thread Paul Berry
--- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b71b44b..52a9bd4 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shade