Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Brian Paul
On 01/02/2012 10:37 PM, Paul Berry wrote: --- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b71b44b..52a9bd4 100644 ---

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
This series is Reviewed-by: Eric Anholt e...@anholt.net With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be passing the oglc tests, except for one more case: They try to ask for whole arrays to be fed back, without [] in the declaration. The clearest text I

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:16, Eric Anholt e...@anholt.net wrote: This series is Reviewed-by: Eric Anholt e...@anholt.net With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be passing the oglc tests, except for one more case: They try to ask for whole arrays to be

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry stereotype...@gmail.com wrote: On 3 January 2012 18:16, Eric Anholt e...@anholt.net wrote: This series is Reviewed-by: Eric Anholt e...@anholt.net With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:56, Eric Anholt e...@anholt.net wrote: On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry stereotype...@gmail.com wrote: On 3 January 2012 18:16, Eric Anholt e...@anholt.net wrote: This series is Reviewed-by: Eric Anholt e...@anholt.net With this and the fix I

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:51, Paul Berry stereotype...@gmail.com wrote: On 3 January 2012 18:16, Eric Anholt e...@anholt.net wrote: This series is Reviewed-by: Eric Anholt e...@anholt.net With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be passing the oglc

[Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-02 Thread Paul Berry
--- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b71b44b..52a9bd4 100644 --- a/src/mesa/main/shaderapi.c +++