[Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

2018-06-01 Thread Jose Fonseca
The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. --- .../auxiliary/driver_trace/tr_context.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/driver_trace/tr_context.c b/src/gallium/auxilia

Re: [Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

2018-06-01 Thread Roland Scheidegger
I am a bit confused by this, so by the looks of it you only dump things (unchanged) for textures, so did it match there? Also, I don't really understand why it doesn't work for buffers neither, even if some parameters don't make sense there, but if it's a transfer this should still be correct? Rol

Re: [Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

2018-06-02 Thread Jose Fonseca
If you lookup the declartion of buffer_subdata and texture_subdata, you'll see the parameters differ for these two methods, except for the very first two. Yet trace_context_transfer_unmap was emitting the same parameters for both. But you're right, I left this half done somehow - I forgot to