[Mesa-dev] [PATCH 1/3] u_format: implement fetch_rgba_uint and fetch_rgba_sint for integer formats

2012-01-02 Thread Marek Olšák
Fetching int as float and vice versa is not allowed. Fetching unsigned int as signed int and vice versa is not allowed either. Doing conversions like that isn't allowed in OpenGL. The three hooks could be consolidated into one fetch hook, which would fetch uint as uint32, sint as sint32, and

Re: [Mesa-dev] [PATCH 1/3] u_format: implement fetch_rgba_uint and fetch_rgba_sint for integer formats

2012-01-02 Thread Dave Airlie
On Mon, Jan 2, 2012 at 1:07 PM, Marek Olšák mar...@gmail.com wrote: Fetching int as float and vice versa is not allowed. Fetching unsigned int as signed int and vice versa is not allowed either. The first is true, the second isn't, otherwise I'd have implemented this that way. Doing

Re: [Mesa-dev] [PATCH 1/3] u_format: implement fetch_rgba_uint and fetch_rgba_sint for integer formats

2012-01-02 Thread Dave Airlie
On Mon, Jan 2, 2012 at 4:40 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Jan 2, 2012 at 3:31 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Jan 2, 2012 at 1:07 PM, Marek Olšák mar...@gmail.com wrote: Fetching int as float and vice versa is not allowed. Fetching unsigned int as signed int

Re: [Mesa-dev] [PATCH 1/3] u_format: implement fetch_rgba_uint and fetch_rgba_sint for integer formats

2012-01-02 Thread Marek Olšák
On Mon, Jan 2, 2012 at 5:56 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Jan 2, 2012 at 4:40 PM, Marek Olšák mar...@gmail.com wrote: On Mon, Jan 2, 2012 at 3:31 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Jan 2, 2012 at 1:07 PM, Marek Olšák mar...@gmail.com wrote: Fetching int as

Re: [Mesa-dev] [PATCH 1/3] u_format: implement fetch_rgba_uint and fetch_rgba_sint for integer formats

2012-01-02 Thread Ian Romanick
On 01/02/2012 09:18 AM, Marek Olšák wrote: On Mon, Jan 2, 2012 at 5:56 PM, Dave Airlieairl...@gmail.com wrote: On Mon, Jan 2, 2012 at 4:40 PM, Marek Olšákmar...@gmail.com wrote: On Mon, Jan 2, 2012 at 3:31 PM, Dave Airlieairl...@gmail.com wrote: On Mon, Jan 2, 2012 at 1:07 PM, Marek