Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Jose Fonseca
On 09/08/15 21:30, Jose Fonseca wrote: On 09/08/15 21:21, Roland Scheidegger wrote: Am 09.08.2015 um 20:08 schrieb Jose Fonseca: On 09/08/15 17:47, Matt Turner wrote: On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Jose Fonseca
On 09/08/15 21:21, Roland Scheidegger wrote: Am 09.08.2015 um 20:08 schrieb Jose Fonseca: On 09/08/15 17:47, Matt Turner wrote: On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as it doesn't define __x86_64__ macro (

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Roland Scheidegger
Am 09.08.2015 um 20:08 schrieb Jose Fonseca: > On 09/08/15 17:47, Matt Turner wrote: >> On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: >>> Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a >>> problem as >>> it doesn't define __x86_64__ macro (it's GCC specific.) >>> >>> Howev

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Jose Fonseca
On 09/08/15 19:08, Jose Fonseca wrote: On 09/08/15 17:47, Matt Turner wrote: On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as it doesn't define __x86_64__ macro (it's GCC specific.) However on Windows long type is

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Jose Fonseca
On 09/08/15 17:47, Matt Turner wrote: On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as it doesn't define __x86_64__ macro (it's GCC specific.) However on Windows long type is guaranteed to be 32bits. Also add an #

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Matt Turner
On Sun, Aug 9, 2015 at 3:57 AM, Jose Fonseca wrote: > Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as > it doesn't define __x86_64__ macro (it's GCC specific.) > > However on Windows long type is guaranteed to be 32bits. > > Also add an #error, as GCC will just warn, n

Re: [Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Roland Scheidegger
Am 09.08.2015 um 12:57 schrieb Jose Fonseca: > Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as > it doesn't define __x86_64__ macro (it's GCC specific.) > > However on Windows long type is guaranteed to be 32bits. > > Also add an #error, as GCC will just warn, not thr

[Mesa-dev] [PATCH 1/3] util: Cope with LONG_BIT not being defined on Windows.

2015-08-09 Thread Jose Fonseca
Neither MSVC nor MinGW defines LONG_BIT. For MSVC this was not a problem as it doesn't define __x86_64__ macro (it's GCC specific.) However on Windows long type is guaranteed to be 32bits. Also add an #error, as GCC will just warn, not throw any error, when no value is returned. Trivial. --- s