Re: [Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

2018-11-13 Thread andrey simiklit
Hello, Thanks a lot for review. Regards, Andrii. On Sat, Nov 10, 2018 at 5:38 AM Timothy Arceri wrote: > Nice! Series is: > > Reviewed-by: Timothy Arceri > > On 10/10/18 9:07 am, Ian Romanick wrote: > > From: Ian Romanick > > > > Section 3.7 (Identifiers) of the GLSL spec says: > > > >

Re: [Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

2018-11-09 Thread Timothy Arceri
Nice! Series is: Reviewed-by: Timothy Arceri On 10/10/18 9:07 am, Ian Romanick wrote: From: Ian Romanick Section 3.7 (Identifiers) of the GLSL spec says: However, as noted in the specification, there are some cases where previously declared variables can be redeclared to change

Re: [Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

2018-11-09 Thread Ian Romanick
bump On 10/09/2018 03:07 PM, Ian Romanick wrote: > From: Ian Romanick > > Section 3.7 (Identifiers) of the GLSL spec says: > > However, as noted in the specification, there are some cases where > previously declared variables can be redeclared to change or add > some property, and

[Mesa-dev] [PATCH 1/3 v2] glsl: prevent qualifiers modification of predeclared variables

2018-10-09 Thread Ian Romanick
From: Ian Romanick Section 3.7 (Identifiers) of the GLSL spec says: However, as noted in the specification, there are some cases where previously declared variables can be redeclared to change or add some property, and predeclared "gl_" names are allowed to be redeclared in a