[Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-13 Thread Kenneth Graunke
This was an embarassingly large amount of copy and pasted code, and it wasn't particularly simple code either. By factoring it out into a helper function, we consolidate the complexity. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 144 +-

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Eric Anholt
Kenneth Graunke writes: > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper function, we consolidate the complexity. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen7_wm_s

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Kenneth Graunke
On 09/16/2013 09:38 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> This was an embarassingly large amount of copy and pasted code, >> and it wasn't particularly simple code either. By factoring it out >> into a helper function, we consolidate the complexity. >> >> Signed-off-by: Kenneth G

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Paul Berry
On 13 September 2013 23:10, Kenneth Graunke wrote: > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper function, we consolidate the complexity. > > Signed-off-by: Kenneth Graunke > I really like

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Paul Berry
On 16 September 2013 09:38, Eric Anholt wrote: > Kenneth Graunke writes: > > > This was an embarassingly large amount of copy and pasted code, > > and it wasn't particularly simple code either. By factoring it out > > into a helper function, we consolidate the complexity. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-17 Thread Kenneth Graunke
On 09/16/2013 02:55 PM, Paul Berry wrote: > On 13 September 2013 23:10, Kenneth Graunke > wrote: > > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper func