[Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-27 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/intel/Android.dev.mk | 35 ++ src/intel/Makefile.am | 1 + src/intel/Makefile.dev.am | 31 +++ src/intel/Makefile.isl.am

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Samuel Iglesias Gonsálvez
What is the idea for src/intel/dev/ ? I'm not against this patch, just asking. Patches 2-4 are, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 27/02/18 21:32, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/Android.dev.mk | 35 > +

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Samuel Iglesias Gonsálvez
On 28/02/18 10:58, Samuel Iglesias Gonsálvez wrote: > > What is the idea for src/intel/dev/ ? > > I'm not against this patch, just asking. > Anyway, this patch has my R-b too. Sam > Patches 2-4 are, > > Reviewed-by: Samuel Iglesias Gonsálvez > > Sam > > > On 27/02/18 21:32, Jordan Justen wrote:

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Jordan Justen
On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: > What is the idea for src/intel/dev/ ? > > I'm not against this patch, just asking. Ken noticed a lot of duplicate lines in the xml for surface formats. (Patch 4). But, then we noticed that removing them makes aubinator fail to nicely prin

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Samuel Iglesias Gonsálvez
On 28/02/18 11:15, Jordan Justen wrote: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: >> What is the idea for src/intel/dev/ ? >> >> I'm not against this patch, just asking. > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Patch 4). But, then we noticed that

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Rafael Antognolli
On Wed, Feb 28, 2018 at 02:15:19AM -0800, Jordan Justen wrote: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: > > What is the idea for src/intel/dev/ ? > > > > I'm not against this patch, just asking. > > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Patch 4)

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Francisco Jerez
Jordan Justen writes: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: >> What is the idea for src/intel/dev/ ? >> >> I'm not against this patch, just asking. > > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Patch 4). But, then we noticed that removing them m

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

2018-02-28 Thread Jordan Justen
On 2018-02-28 12:53:01, Francisco Jerez wrote: > Jordan Justen writes: > > > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: > >> What is the idea for src/intel/dev/ ? > >> > >> I'm not against this patch, just asking. > > > > Ken noticed a lot of duplicate lines in the xml for surface