[Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery Only uncompressed formats have a non-void type and actual components per pixel. Rename _mesa_format_to_type_and_comps to _mesa_uncompressed_format_to_type_and_comps and require callers to check if the format is not compressed. Cc: Jason Ekstrand Signed-off-by: Nanley Chery -

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-14 Thread Chad Versace
On Tue 11 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > Only uncompressed formats have a non-void type and actual components per > pixel. > Rename _mesa_format_to_type_and_comps to > _mesa_uncompressed_format_to_type_and_comps and require callers to check if > the format is not compress

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-17 Thread Nanley Chery
On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace wrote: > On Tue 11 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > Only uncompressed formats have a non-void type and actual components per > pixel. > > Rename _mesa_format_to_type_and_comps to > > _mesa_uncompressed_format_to_type_and_c

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-17 Thread Nanley Chery
Cc'ing Brian. I'm planning to make a patch to implement the first (3-step) solution. On Mon, Aug 17, 2015 at 3:45 PM, Nanley Chery wrote: > > On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace > wrote: > >> On Tue 11 Aug 2015, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Only uncompressed

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-18 Thread Chad Versace
On Mon 17 Aug 2015, Nanley Chery wrote: > Cc'ing Brian. > > I'm planning to make a patch to implement the first (3-step) solution. Sounds good to me. [reproducing in-person conversation for mesa-dev] For the functions touched by patches 1/4 and 2/4, Mesa verifies (pre-patch) that each functi