Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

2017-06-06 Thread Daniel Stone
Hi Eric, On 6 June 2017 at 18:27, Eric Engestrom wrote: > On Tuesday, 2017-06-06 18:18:31 +0100, Daniel Stone wrote: >> diff --git a/src/egl/drivers/dri2/egl_dri2.c >> b/src/egl/drivers/dri2/egl_dri2.c >> index d31a0bf8e0..7175e827c9 100644 >> --- a/src/egl/drivers/dri2/egl_dri2.c >> +++ b/src/e

Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

2017-06-06 Thread Eric Engestrom
On Tuesday, 2017-06-06 18:18:31 +0100, Daniel Stone wrote: > Since the EGL attributes are signed integers, a straight OR would > also perform sign extension, > > Fixes: 6f10e7c37a ("egl/dri2: Create EGLImages with dmabuf modifiers") > Cc: Varad Gautam > Signed-off-by: Daniel Stone > --- > src/e

[Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

2017-06-06 Thread Daniel Stone
Since the EGL attributes are signed integers, a straight OR would also perform sign extension, Fixes: 6f10e7c37a ("egl/dri2: Create EGLImages with dmabuf modifiers") Cc: Varad Gautam Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 de