Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

There are a couple nits and suggestions for small follow-ups below. With the couple nits (all in ast_to_hir.cpp) fixed, this patch is Reviewed-by: Ian Romanick On 07/08/2016 03:18 PM, Matt Turner wrote: > I do appreciate the cleverness, but unfortunately it prevents a

Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

ping ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

On Fri, Jul 8, 2016 at 3:18 PM, Matt Turner wrote: > I do appreciate the cleverness, but unfortunately it prevents a lot more > cleverness in the form of additional compiler optimizations brought on > by -fstrict-aliasing. > > No difference in OglBatch7 (n=20). > >

[Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

I do appreciate the cleverness, but unfortunately it prevents a lot more cleverness in the form of additional compiler optimizations brought on by -fstrict-aliasing. No difference in OglBatch7 (n=20). Co-authored-by: Davin McCall --- I took Ian's suggestion to add

Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

On 06/27/2016 02:42 PM, Matt Turner wrote: > I do appreciate the cleverness, but unfortunately it prevents a lot more > cleverness in the form of additional compiler optimizations brought on > by -fstrict-aliasing. > > No difference in OglBatch7 (n=20). > > Co-authored-by: Davin McCall

[Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

I do appreciate the cleverness, but unfortunately it prevents a lot more cleverness in the form of additional compiler optimizations brought on by -fstrict-aliasing. No difference in OglBatch7 (n=20). Co-authored-by: Davin McCall --- src/compiler/glsl/ast.h