Re: [Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

2011-09-27 Thread Eric Anholt
On Mon, 26 Sep 2011 14:28:25 -0700, Kenneth Graunke wrote: > On 09/25/2011 09:21 AM, Paul Berry wrote: > > Since the i965 driver supports 8 clipping planes now, we need 4 bits > > to store the number of user clipping planes, not 3. > > > > In theory this isn't strictly necessary, since brw_clip.

Re: [Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

2011-09-27 Thread Paul Berry
On 26 September 2011 15:09, Kenneth Graunke wrote: > On 09/25/2011 09:21 AM, Paul Berry wrote: > > Since the i965 driver supports 8 clipping planes now, we need 4 bits > > to store the number of user clipping planes, not 3. > > > > In theory this isn't strictly necessary, since brw_clip.h is only

Re: [Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

2011-09-26 Thread Kenneth Graunke
On 09/25/2011 09:21 AM, Paul Berry wrote: > Since the i965 driver supports 8 clipping planes now, we need 4 bits > to store the number of user clipping planes, not 3. > > In theory this isn't strictly necessary, since brw_clip.h is only used > on pre-GEN6, and pre-GEN6 only advertises support for

Re: [Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

2011-09-26 Thread Kenneth Graunke
On 09/25/2011 09:21 AM, Paul Berry wrote: > Since the i965 driver supports 8 clipping planes now, we need 4 bits > to store the number of user clipping planes, not 3. > > In theory this isn't strictly necessary, since brw_clip.h is only used > on pre-GEN6, and pre-GEN6 only advertises support for

[Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

2011-09-25 Thread Paul Berry
Since the i965 driver supports 8 clipping planes now, we need 4 bits to store the number of user clipping planes, not 3. In theory this isn't strictly necessary, since brw_clip.h is only used on pre-GEN6, and pre-GEN6 only advertises support for 6 clipping planes, but it seems wise to err on the s