Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-15 Thread Stéphane Marchesin
On Fri, Mar 15, 2019 at 8:55 AM Jose Fonseca wrote: > > On 14/03/2019 19:37, Brian Paul wrote: > > When st_texture_release_all_sampler_views() is called the texture may > > have sampler views belonging to several contexts. If we unreference a > > sampler view and its refcount hits zero, we need

Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-15 Thread Brian Paul
On 03/15/2019 09:54 AM, Jose Fonseca wrote: On 14/03/2019 19:37, Brian Paul wrote: When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts.  If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy

Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-15 Thread Jose Fonseca
On 14/03/2019 19:37, Brian Paul wrote: When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts. If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy the sampler view with the same context which

Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-14 Thread Mathias Fröhlich
Hi Brian, the full package looks great and makes a lot of sense! Reviewed-by: Mathias Fröhlich best Mathias On Thursday, 14 March 2019 20:37:09 CET Brian Paul wrote: > When st_texture_release_all_sampler_views() is called the texture may > have sampler views belonging to several contexts.

[Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-14 Thread Brian Paul
When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts. If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy the sampler view with the same context which created it. This was not the case with