Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-18 Thread Dylan Baker
Quoting Jason Ekstrand (2017-07-17 10:42:05) > Generally available things tend to be painful in Python because you have to > set > the python path if you ever want to import anything that isn't in your > directory.  That doesn't mean we shouldn't do it, just that the pain may be > too > high. 

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Ian Romanick
On 07/17/2017 10:54 AM, Emil Velikov wrote: > On 15 July 2017 at 02:39, Ian Romanick wrote: >> From: Ian Romanick >> >> The old table based spirv_*_to_string functions would return NULL for >> any values "inside" the table that didn't have entries.

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Emil Velikov
On 17 July 2017 at 18:54, Emil Velikov wrote: > I think you missed "git add spirvjson" Nope, it's there as PATCH 1.1/8. Pardon for the noise. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Emil Velikov
On 15 July 2017 at 02:39, Ian Romanick wrote: > From: Ian Romanick > > The old table based spirv_*_to_string functions would return NULL for > any values "inside" the table that didn't have entries. The tables also > needed to be updated by hand

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Ian Romanick
On 07/17/2017 10:09 AM, Ian Romanick wrote: > On 07/14/2017 09:22 PM, Jason Ekstrand wrote: >> What you have is fine here but I've been really liking the style that's >> used in mesa/main/format_fallbacks.py and the anv_extensions.py that I >> sent out which does >> >> COPYRIGHT=""" >> \* The

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Jason Ekstrand
On Mon, Jul 17, 2017 at 10:09 AM, Ian Romanick wrote: > On 07/14/2017 09:22 PM, Jason Ekstrand wrote: > > On Fri, Jul 14, 2017 at 6:39 PM, Ian Romanick > > wrote: > > > > From: Ian Romanick

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-17 Thread Ian Romanick
On 07/14/2017 09:22 PM, Jason Ekstrand wrote: > On Fri, Jul 14, 2017 at 6:39 PM, Ian Romanick > wrote: > > From: Ian Romanick > > > The old table based spirv_*_to_string

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-14 Thread Jason Ekstrand
On Fri, Jul 14, 2017 at 6:39 PM, Ian Romanick wrote: > From: Ian Romanick > > The old table based spirv_*_to_string functions would return NULL for > any values "inside" the table that didn't have entries. The tables also > needed to be updated

[Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-14 Thread Ian Romanick
From: Ian Romanick The old table based spirv_*_to_string functions would return NULL for any values "inside" the table that didn't have entries. The tables also needed to be updated by hand each time a new spirv.h was imported. Generate the file instead.