Re: [Mesa-dev] [PATCH 10/10] ac/nir: remove some useless integer casts for ALU operations

2019-04-10 Thread Marek Olšák
On Wed, Apr 10, 2019 at 7:44 PM Timothy Arceri wrote: > Before I attempt to review, have you run piglit on this series with > radeonsi nir? > That's a good idea. If there is no piglit regression on radeonsi, the series is: Reviewed-by: Marek Olšák Marek

Re: [Mesa-dev] [PATCH 10/10] ac/nir: remove some useless integer casts for ALU operations

2019-04-10 Thread Timothy Arceri
Before I attempt to review, have you run piglit on this series with radeonsi nir? On 11/4/19 1:16 am, Samuel Pitoiset wrote: Sources are always casted to integers. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 16 deletions(-)

[Mesa-dev] [PATCH 10/10] ac/nir: remove some useless integer casts for ALU operations

2019-04-10 Thread Samuel Pitoiset
Sources are always casted to integers. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 16 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3dfcbacdef4..f1c082c1130 100644 ---