Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-16 Thread Eric Engestrom
On Tuesday, 2016-11-15 12:27:44 -0500, Rob Clark wrote: > see drm_fourcc.h (if the extension txt didn't mention that, perhaps it should) It does :) These attribute values together form an unsigned 64-bit value called a format modifier. Format modifiers are specified by drm_fourcc.

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-16 Thread Varad Gautam
On Wed, Nov 16, 2016 at 12:25 PM, Michel Dänzer wrote: > On 15/11/16 11:24 PM, Varad Gautam wrote: >> From: Varad Gautam >> >> drivers should implement pipe_screen->get_modifiers_for_format and >> advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format >> modifier queries. > > Is ther

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-15 Thread Michel Dänzer
On 15/11/16 11:24 PM, Varad Gautam wrote: > From: Varad Gautam > > drivers should implement pipe_screen->get_modifiers_for_format and > advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format > modifier queries. Is there any point in having the PIPE_CAP_QUERY_DMABUF_MODIFIERS cap, vs

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-15 Thread Rob Clark
see drm_fourcc.h (if the extension txt didn't mention that, perhaps it should) BR, -R On Tue, Nov 15, 2016 at 12:23 PM, Roland Scheidegger wrote: > It looks like there aren't any possible modifier bits defined, so how is > this supposed to work? > > Roland > > Am 15.11.2016 um 15:24 schrieb Vara

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-15 Thread Roland Scheidegger
It looks like there aren't any possible modifier bits defined, so how is this supposed to work? Roland Am 15.11.2016 um 15:24 schrieb Varad Gautam: > From: Varad Gautam > > drivers should implement pipe_screen->get_modifiers_for_format and > advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to

[Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

2016-11-15 Thread Varad Gautam
From: Varad Gautam drivers should implement pipe_screen->get_modifiers_for_format and advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format modifier queries. Signed-off-by: Varad Gautam --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/fre